Skip to content

TC-Pairs reports the wrong number of lines read from input track data files. #1725

@JohnHalleyGotway

Description

@JohnHalleyGotway

Describe the Problem

This is a pretty low priority bug. The log messages that TC-Pairs prints about the number of lines read from input track data files are not accurate. Note that this bug does not appear in MET version 9.1. It was introduced during development toward the 10.0.0 release.

For example, running one of the tests from unit_tc_pairs.xml:

DEBUG 4: [File 21 of 21] Used 12 of 13 lines read from file "/Volumes/d1/projects/MET/MET_unit_test/MET_test_input/tc_data/adeck/aal212010.dat"

There are actually 13 ATCF lines in this file, not 12. I'd always just assumed there was a header line being skipped but that's not the case. When we add a new ATCFLine to an existing track, that counter is correctly incremented. But when we use an ATCFLine to create a new track, the code fails to increment the counter.

This is quick and easy 1 line fix.

Expected Behavior

The log message should reflect the actual data lines used from each input file.

Environment

Describe your runtime environment:
Can be reproduced on any machine.

To Reproduce

Describe the steps to reproduce the behavior:
Run the tests in unit_tc_pairs.xml

Relevant Deadlines

None

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: John HG
  • Select scientist(s) or no scientist required: No scientist required but ask @j-opatz to review

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to relevant bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
  • Close this issue.

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions