-
Notifications
You must be signed in to change notification settings - Fork 26
Description
Describe the Problem
This issue arose via a met-help question from NOAA/GSL:
https://rt.rap.ucar.edu/rt/Ticket/Display.html?id=99708
Passing an edeck file to TC-Pairs which contains more than just the RI line type causes the tool to stop reading the input file after the first unexpected line type.
Expected Behavior
Edeck files from NHC often contain more than just the RI line type that TC-Pairs currently supports. TC-Pairs should read all available input RI lines and ignore the other unsupported line types.
Environment
Describe your runtime environment:
Behavior is not tied to a specific platform or OS.
Replicated this behavior on my Mac Laptop using both MET version 9.1 and the latest development version.
To Reproduce
Describe the steps to reproduce the behavior:
1. Download these edeck and bdeck files:
2020072112.eep072020.txt
2020072112.bep072020.txt
2. Run tc_pairs:
tc_pairs -edeck edeck/2020072112.eep072020.txt -bdeck bdeck/2020072112.bep072020.txt -config TCPairsConfig_default -v 3
3. Observe the log messages showing 0 lines were read. That is because the first line is NOT a rapid intensification "RI" line type:
DEBUG 2: Processing 1 EDECK file(s).
WARNING:
WARNING: int ATCFProbLine::read_line(LineDataFile * ldf) -> unexpected ATCF line type (ProbGN)
WARNING:
DEBUG 3: Used 0 of 0 lines read from 1 file(s).
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
2790541
Define the Metadata
Assignee
- Select engineer(s) or no engineer required: John HG
- Select scientist(s) or no scientist required: Recommend @KathrynNewman to review
Labels
- Select component(s)
- Select priority
- Select requestor(s)
Projects and Milestone
- Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
- Select milestone to relevant bugfix version
Define Related Issue(s)
Consider the impact to the other METplus components.
Bugfix Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of main_<Version>.
Branch name:bugfix_<Issue Number>_main_<Version>_<Description>
- Fix the bug and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Push local changes to GitHub.
- Submit a pull request to merge into main_<Version>.
Pull request:bugfix <Issue Number> main_<Version> <Description>
- Define the pull request metadata, as permissions allow.
Select: Reviewer(s), Project(s), Milestone, and Linked issues - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Complete the steps above to fix the bug on the develop branch.
Branch name:bugfix_<Issue Number>_develop_<Description>
Pull request:bugfix <Issue Number> develop <Description>
- Close this issue.