Skip to content

Update MET unit test logic to unset environment variables after each test. #1624

@JohnHalleyGotway

Description

@JohnHalleyGotway

Describe the Enhancement

George found a small omission for the python_numpy_point_stat tests in unit_python.xml. The Point-Stat config file references the ${OBS_COMMAND} environment variable. But that isn't actually set by the test. Instead, it inherits the setting from the previous test.

This task is to fix that omission. In addition, update the unit test logic. After each test is run, unset any environment variables that were explicitly set for that test. This will ensure that each test can run independently.

Time Estimate

2 hr

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None required.

Relevant Deadlines

None.

Funding Source

None.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: John HG
  • Select scientist(s) or no scientist required: none needed

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions