-
Notifications
You must be signed in to change notification settings - Fork 26
Description
Describe the Problem
Todd Spindler from NOAA/EMC wrote with questions about python embedding of MPR data in Stat-Analysis. He pointed out that read_ascii_mpr.py does not read the FIRST (VERSION) or LAST (CLIMO_CDF) column from the input .stat MPR line types. I've added as a comment to this issue my email response to him. The punchline is that skipping the first column is by design, but skipping the last column is a bug.
Expected Behavior
Python embedding of MPR data in Stat-Analysis should include the CLIMO_CDF column.
Environment
Describe your runtime environment:
- Machine: Any platform. I demonstrated on my Mac laptop.
- OS: MacOS
- Software version number(s): MET main_v9.1 branch
To Reproduce
Describe the steps to reproduce the behavior:
- Save this version of read_ascii_mpr.py from main_v9.1 in which the MPR data is printed out:
read_ascii_mpr.py.txt - Save this sample MPR data file:
sample_mpr.txt - Run these commands:
mv read_ascii_mpr.py.txt read_ascii_mpr.py
stat_analysis -lookin python ./read_ascii_mpr.py sample_mpr.txt -job aggregate_stat -line_type MPR -out_line_type sl1l2 -by FCST_VAR
Inspect the output printed to the screen and note that the last (CLIMO_CDF) column is not included.
Relevant Deadlines
NONE.
Funding Source
2791541
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required: no scientist required
Labels
- Select component(s)
- Select priority
- Select requestor(s)
Projects and Milestone
- Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
- Select milestone to relevant bugfix version
Define Related Issue(s)
Consider the impact to the other METplus components.
Bugfix Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of main_<Version>.
Branch name:bugfix_<Issue Number>_main_<Version>_<Description>
- Fix the bug and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Push local changes to GitHub.
- Submit a pull request to merge into main_<Version>.
Pull request:bugfix <Issue Number> main_<Version> <Description>
- Define the pull request metadata, as permissions allow.
Select: Reviewer(s), Project(s), Milestone, and Linked issues - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Complete the steps above to fix the bug on the develop branch.
Branch name:bugfix_<Issue Number>_develop_<Description>
Pull request:bugfix <Issue Number> develop <Description>
- Close this issue.