Skip to content

The set_attr_accum option is setting the lead time instead of the accumulation time. #1646

@JohnHalleyGotway

Description

@JohnHalleyGotway

Describe the Problem

While answering a met-help question for RT 9891 from the UK MetOffice, I tested out the set_attr options to manually define the gridded metadata. During that testing, I found that set_attr_accum does not have the desired effect. It sets the lead time instead of the accumulation interval.

It's a simple copy/paste error that's a one-liner to fix.

Expected Behavior

Defining set_attr_accum should actually override the accumulation interval read from the input data file.

Environment

Describe your runtime environment:
1. Machine: Replicated behavior on my Mac
2. OS: MacOS
3. Software version number(s): exists in met-9.1.2 and in the develop branch

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to the top-level MET directory of the develop branch and run:

bin/plot_data_plane \
data/sample_fcst/2005080700/wrfprs_ruc13_12.tm00_G212 plot.ps \
'name="TMP"; level="Z2"; set_attr_accum="37";'
-v 4

2: Note these 2 log message:

DEBUG 3: Parsed set_attr_accum = "37"
DEBUG 4:      accum time: 000000

So it parsed it correctly but did not apply it correctly.

Relevant Deadlines

None.

Funding Source

None.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: John HG
  • Select scientist(s) or no scientist required: No scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to relevant bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
  • Close this issue.

Metadata

Metadata

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions