Skip to content

File list parsing logic continues to fail in the Nightly Build for tc_gen. #1508

@JohnHalleyGotway

Description

@JohnHalleyGotway

Describe the Problem

The file list parsing logic continues to fail in the Nightly Build for tc_gen. This issue is related to #1484.
The fix for that apparently did not resolve all of the issues. The NB failed for main_v9.1 on 10/4/20 and develop on 10/3/20. Both times, it failed the same way. The reference version ran fine, but the tip of the branch failed on tc_gen. It processed the input ATCF files as being file lists instead of actual ATCF files:

TEST: tc_gen_2016  - FAIL - 859.097 sec
/d3/projects/MET/MET_regression/main_v9.1/NB20201004/MET-main_v9.1/met/share/met/../../bin/tc_gen \
      -genesis /d3/projects/MET/MET_test_data/unit_test/tc_data/genesis/suite1/2016*/genesis*2016* \
      -track /d3/projects/MET/MET_test_data/unit_test/tc_data/genesis/atcf/2016 \
      -config /d3/projects/MET/MET_regression/main_v9.1/NB20201004/MET-main_v9.1/test/config/TCGenConfig_2016 \
      -out /d3/projects/MET/MET_regression/main_v9.1/NB20201004/MET-main_v9.1/test_output/tc_gen/tc_gen_2016 \
      -log /d3/projects/MET/MET_regression/main_v9.1/NB20201004/MET-main_v9.1/test_output/tc_gen/tc_gen_2016.log \
      -v 2
DEBUG 1: [Source 1 of 4327693] Genesis Source: TG,, Model Suffix: (nul)

Expected Behavior

The tc_gen tool in MET should correctly discriminate between file lists and ATCF files.

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: John HG
  • Select scientist(s) or no scientist required: none required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to relevant bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
  • Close this issue.

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions