-
Notifications
You must be signed in to change notification settings - Fork 26
Description
Describe the Enhancement
The tc_gen tool currently writes Debug(4) log messages for each pair indicating how it was classified.
(1) HIT:
DEBUG 4: SUI1 20160525_120000 initialization, 51 lead, 20160527_150000 genesis at (28.4, -73.6) is a HIT for BEST 20160527_180000 genesis at (28.3, -74.4).
DEBUG 4: SUI1 20160813_120000 initialization, 36 lead, 20160815_000000 genesis at (8.5, -23.5) is a HIT for CARQ 20160815_120000 genesis at (9.2, -23.7).
(2) MISS:
DEBUG 4: BEST 20160913_060000 genesis at (27.3, -80.2) for 20160908_060000 initialization, 120 lead is a MISS.
(3) FALSE ALARM:
DEBUG 4: SUI1 20160101_000000 initialization, 39 lead, 20160102_150000 genesis at (10.5, -70.9) is a FALSE ALARM.
This task is to provide the option to write this detailed log information to the actual output files by defining a new STAT line type. This is analogous to the RIRW_MPR line type written by TC-Stat. However that line is only written to the log file and not a fully support STAT output line type. Recommend adding a GENESIS_MPR line type that includes the ADECK and BDECK location and timing information and classifies the pair as being a HIT, MISS, FALSE ALARM, or DISCARD (where the discard logic is described by MET #1448).
One compilation is that Stat-Analysis would also need to be enhanced to be able parse this new STAT line type. However, I'd recommend that Stat-Analysis only support the filtering job type for this new line type and nothing else.
Time Estimate
Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.
Sub-Issues
Consider breaking the enhancement down into sub-issues.
- Add a checkbox for each sub-issue here.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
- Select engineer(s) or no engineer required: John HG
- Select scientist(s) or no scientist required: Dan H and Kathryn
Labels
- Select component(s)
- Select priority
- Select requestor(s)
Projects and Milestone
- Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
- Select milestone to next major version milestone or "Future Versions"
Define Related Issue(s)
Consider the impact to the other METplus components.
- METplus, MET, METdatadb, METviewer, METexpress, METcalcpy, METplotpy
Adding a new STAT line type would require METviewer and METdatadb to handle it.
Enhancement Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of develop.
Branch name:feature_<Issue Number>_<Description>
- Complete the development and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Push local changes to GitHub.
- Submit a pull request to merge into develop.
Pull request:feature <Issue Number> <Description>
- Define the pull request metadata, as permissions allow.
Select: Reviewer(s), Project(s), Milestone, and Linked issues - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Close this issue.