FIX #124 - Return if there is no active gesture #169
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
approved these changes
Jun 28, 2019
robinhouston
added a commit
to kiln/d3-zoom
that referenced
this pull request
Jul 16, 2019
It seems that the behaviour of Chrome on Android differs from the behaviour of Safari on iOS in the following respect: when a multitouch event is initiated by touching two or more fingers to the screen near-simultaneously, iOS Safari will fire a single touchstart event that includes all the touches (as both event.touches and event.changedTouches) whereas Android Chrome will fire a sequence of touchstart events: - one with touches.length == 1 and changedTouches.length == 1 - followed by one with touches.length == 2 and changedTouches.length == 1 In other words, the behaviour on Android Chrome when the screen is touched with two fingers simultaneously is the same as the behaviour on iOS Safari when you touch it first with one finger and then a second. The change in PR d3#169 makes it possible to ignore single-touch gestures on iOS Safari, but this fails on Android Chrome because the first touch is never recorded. When the second touch is processed, the changedTouches array contains only the second touch. This commit changes the behaviour of the touchstarted handler to consider all the touches in the event, rather than just the new touches.
|
This should go out together with #176. |
mbostock
pushed a commit
that referenced
this pull request
Aug 5, 2019
It seems that the behaviour of Chrome on Android differs from the behaviour of Safari on iOS in the following respect: when a multitouch event is initiated by touching two or more fingers to the screen near-simultaneously, iOS Safari will fire a single touchstart event that includes all the touches (as both event.touches and event.changedTouches) whereas Android Chrome will fire a sequence of touchstart events: - one with touches.length == 1 and changedTouches.length == 1 - followed by one with touches.length == 2 and changedTouches.length == 1 In other words, the behaviour on Android Chrome when the screen is touched with two fingers simultaneously is the same as the behaviour on iOS Safari when you touch it first with one finger and then a second. The change in PR #169 makes it possible to ignore single-touch gestures on iOS Safari, but this fails on Android Chrome because the first touch is never recorded. When the second touch is processed, the changedTouches array contains only the second touch. This commit changes the behaviour of the touchstarted handler to consider all the touches in the event, rather than just the new touches.
|
Merged as a84dba2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to fix issue #124
I guess PR #125 would be an alternative fix, and would certainly solve our problem too, but the maintainers don't seem keen on merging it?