ISO 8601 year (%G and %g) #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @BrianMitchL for your work on #37 that makes this PR easy. |
Fil
requested changes
Jun 5, 2020
It's been a while :D I will do so |
|
@Fil Rebased :) |
Fil
approved these changes
Jun 8, 2020
There was a problem hiding this comment.
Testing, I was suprised that there are sometimes 53 weeks!
"2021-01-03 = Sun week 53 2020"
but I cross-checked with http://blog.stevenlevithan.com/archives/date-time-format and with https://www.epochconverter.com/weeknumbers, and it seems to be true :)
This was referenced Feb 2, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the example of #37 and the documentation of strftime, I suggest adding the
%Gand%gspecifiers.In time-series with a weekly granularity spanning on more than one year, the format
Week %V %Yseems appropriate.However, for the end of 2018, it displays the following:
Week 52 2018,Week 01 2018.This is because the first day of the first ISO week of 2019 is December 31st 2018, hence is year is
2018.Instead, we would like to display the year that correspond to the ISO week with
Week %V %G:Week 52 2018,Week 01 2019.The parsing operation doesn't need any work according to tests:
%Gand%gare just aliases for%Yand%y.