Arabic months names #100
Merged
Arabic months names #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The locale for Arabic is ar-EG.json which uses the Egyptian months (transliterated from English) this new file uses the Arabic months used by the Levant Arabic countries. |
Fil
requested changes
Oct 8, 2021
There was a problem hiding this comment.
Can you please double-check the month names? I can't read Arabic, but it looks like the first month (January) is written the same as December; it should probably be كانون الثّاني.
Also it seems that we should add a shaddé on other names:
January:
كانون الثّاني
December:
كانون الأوّل
July:
تمّوز
May:
أيّار
October:
تشرين الأوّل
November:
تشرين الثّاني
Here's a more readable version of the current proposal:
|
Yes Fil January should be كانون الثّاني. The shadda is not necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.