Skip to content

Added nl-BE locale #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2021
Merged

Added nl-BE locale #104

merged 1 commit into from
Dec 4, 2021

Conversation

j-dc
Copy link
Contributor

@j-dc j-dc commented Oct 26, 2021

nl-BE uses / as date separator

Fil
Fil approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a reference. On wikipedia I see

(dd/mm/yyyy)[19] or (dd.mm.yyyy)[20][21]

but no mention of which is the most common occurrence.

@j-dc
Copy link
Contributor Author

j-dc commented Nov 24, 2021

I could change wikipedia for you... ;-) ;-) But the following code is how browsers do it. I hope this is enough of a reference for you?

The dd.mm.yyyy format is indeed accepted in this country, but it feels like something my grandfather used..

var date = new Date();
console.log(new Intl.DateTimeFormat('nl-NL').format(date));
console.log(new Intl.DateTimeFormat('nl-BE').format(date));

Output:
24-11-2021
24/11/2021

https://jsfiddle.net/gw9Ltho8/

@mbostock mbostock merged commit 092d858 into d3:main Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fil Fil Fil approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@j-dc @Fil @mbostock @DevAlsicJanDeclercq