Skip to content

Basic d3shape.arc() broken by recent patch #143

@jeremybalog

Description

@jeremybalog

I believe this fix has created a new issue: 52e069b

Everything was working perfectly fine previously, but now our code is producing errors. Consider the following code:

const radians = 5.7
const arc = d3shape.arc()
      .startAngle( 0 )
      .endAngle( d => {
        return radians
      })
      .innerRadius( d => {
        return 70 - ( d.index * 20 )
      })
      .outerRadius( d => {
        return 90 - ( d.index * 20 )
      })
      .cornerRadius( 10 )

We can all agree that there are 2 * Math.PI = ~6.28 radians in a circle. By changing the radians variable, this is the output of the arcs:

const radians = 5.7
image

const radians = 5.8
image

const radians = 5.9
image

const radians = 6.0
image

const radians = 6.1
image

const radians = 6.2
image

const radians = 6.3
image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions