Skip to content

String concatenation. #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2016
Merged

String concatenation. #11

merged 3 commits into from
Nov 18, 2016

Conversation

mbostock
Copy link
Member

Supersedes #9.

@billneff79
Copy link
Contributor

You had asked in my prior pull request if this was actually a performance improvement outside of the micro-bench we provided, and for our use-case it is. We have a graph with multiple lines on it that have thousands of points. We re-draw those lines when users brush/scroll (the lines are dynamic, so can't just pan/zoom with clipping). This function stood out as the biggest CPU issue in performance tests, which is what led to this optimization. We npm linke'd our mod into our project and did notice a real-world performance increase - helped about 10% in total CPU time for the entire graph, and moved this function out of the top offenders performance wise.

@mbostock
Copy link
Member Author

Okay. I’m happy to try it and see if anyone complains (or rejoices).

@mbostock mbostock merged commit b2295e5 into master Nov 18, 2016
@mbostock mbostock deleted the concat branch November 18, 2016 18:42
@mbostock mbostock mentioned this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants