Skip to content

Seemingly non-weird ball collection throws an error in d3.packEnclose() #188

@esperanc

Description

@esperanc

The following set of balls throws an error:

let weirdBalls = [
  { x: 14.5, y: 48.5, r: 7.585 },
  { x: 9.5, y: 79.5, r: 2.585 },
  { x: 15.5, y: 73.5, r: 8.585 }
] 
d3.packEnclose(weirdBalls)

Note that these do not seem weird in the sense of having centers that are too close or too small/too big radii.
I tracked down the error to function encloseBasis3, which has the following conditional assignment:

const r = -(A ? (B + Math.sqrt(B * B - 4 * A * C)) / (2 * A) : C / B);

For this particular data set, A == 4.440892098500626e-16, and my proposed solution is to test for a 'small enough' A :

const r = -(Math.abs(A) > 1e-10
      ? (B + Math.sqrt(B * B - 4 * A * C)) / (2 * A)
      : C / B);

This seems to work in a project which creates quite a few circles, but there is probably a better solution.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions