Proper clipping of degenerate polygons: #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of adding epsilons at the "clipcircle" stage, we pass an explicit message in coordinate z that this point should not be mixed with the previous point, and add the epsilons later, at the "rejoin" stage. Closes #196 and vega/vega#2572 Relevant notebooks: - https://observablehq.com/d/4175cc6263b949d1 (reproduces the original bug) - https://observablehq.com/d/32bce1e0b8e4f9a1 (fixes the bug with geoStitch) - https://observablehq.com/d/5380dd24622eca74 (reduced test case) - https://observablehq.com/d/495020ca139c39bd (images for the unit test in this commit)
|
(I also tested the code with d3-geo-projection and d3-geo-polygon. All unit tests and visual tests pass.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of adding epsilons at the "clipcircle" stage, we pass an explicit message in coordinate z that this point should not be mixed with the previous point, and add the epsilons later, at the "rejoin" stage.
Closes #196 and vega/vega#2572
Relevant notebooks: