Skip to content

remove descendingDefined, document ascendingDefined, add a few tests #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2021
Merged

remove descendingDefined, document ascendingDefined, add a few tests #224

merged 1 commit into from
Aug 12, 2021

Conversation

Fil
Copy link
Member

@Fil Fil commented Aug 5, 2021 •
edited
Loading

There is a surprise with the handling of undefined in sort:

d3.sort([undefined, null]);           // [null, undefined]
d3.sort([undefined, null], (d) => d); // [undefined, null]

I think we can live with that (fixing it is probably too costly, and for what purpose…), but I documented it in a unit test.

@Fil Fil requested a review from mbostock August 5, 2021 09:29
@Fil Fil mentioned this pull request Aug 5, 2021
Closed
@mbostock mbostock merged commit 67ad4f1 into mbostock/ascending-defined Aug 12, 2021
@mbostock mbostock deleted the fil/ascending-defined-refined branch August 12, 2021 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock Awaiting requested review from mbostock

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fil @mbostock