Skip to content

Conversation

nbarton915
Copy link
Contributor

Summary
Issues history (including individual issues view) currently always shows Resolved after <x time> of Downtime even if the issue severity is marked as disrupted.

This change seeks to remove the of Downtime or language equivalent if the issue severity is anything other than down. The approach is to avoid grammar and i18n changes while also acknowledging the issue's severity.

Change
Minimal change to only apply the ofDowntime mapped text if the issue severity is down

Test plan
Pre-Reqs

  • Have an issues matching to following criteria
    • severity is down and resolved after time diff is over 1 minute
    • severity is disrupted and resolved after time diff is over 1 minute
    • severity is down and resolved after time diff is over 1 hour
    • severity is disrupted and resolved after time diff is over 1 hour
  • Ensure disableIncidentHistory: false

Test Cases
After serving up the page check the following scenarios

  • Assert issues with disrupted severity do no show ofDowntime mapped text (of Downtime)..
    • in issues history (short) view
    • in individual issue view
  • Assert issues with down severity show ofDowntime mapped text (of Downtime)..
    • in issues history (short) view
    • in individual issue view

Screen Shots
image

image

image

image

Closing issues
Closes #264

@mistermantas
Copy link
Member

thank you once again!

@mistermantas mistermantas merged commit 3bffcaa into cstate:dev Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants