Skip to content

Conversation

TheWhackFactory
Copy link

@TheWhackFactory TheWhackFactory commented Oct 29, 2020

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Tagalog translations

Test plan

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

Doesn't change testing.

Closing issues

Closes #152

Please accept as part of Hacktoberfest

@mistermantas
Copy link
Member

Hi, I'm sorry but it doesn't look like you followed the instructions fully. Also, I hope you see the problem yourself, but there's thirty nine files changed -- that should not be the case, new translations only need 2 files changed.

To accept this for Hacktoberfest, please create a new PR with a new fork and make sure you are adding 1 file and editing the Netlify CMS config, as per the documentation. I also think you didn't edit the first comment and left it at "English" which this isn't. Thank you.

@mistermantas
Copy link
Member

mistermantas added a commit that referenced this pull request Dec 12, 2020
@mistermantas mistermantas mentioned this pull request Dec 12, 2020
mistermantas added a commit that referenced this pull request Dec 12, 2020
@mistermantas
Copy link
Member

This will be implemented in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants