Skip to content

Fix mypy error when trying to update HeaderValueMatcher.DEFAULT_MATCHERS #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 26, 2022
Merged

Fix mypy error when trying to update HeaderValueMatcher.DEFAULT_MATCHERS #94

merged 2 commits into from
Jan 26, 2022

Conversation

MaxShvets
Copy link
Contributor

This addresses #93.

@csernazs
Copy link
Owner

csernazs commented Jan 25, 2022 •
edited
Loading

Thanks for the PR!

Could you please try it with MutableMapping? I think that the issue was that Mapping doesn't have __setitem__.
Theoretically speaking, I thing MutableMapping would cover it better but YMMV. If you don't think so (or you don't want to put the extra effort) then I'm happy to approve this in its current form, just let me know.

@MaxShvets
Copy link
Contributor Author

I think that the issue was that Mapping doesn't have setitem.

I think you're right. MutableMapping works, I pushed a new commit

@csernazs csernazs merged commit 55b776f into csernazs:master Jan 26, 2022
@csernazs csernazs mentioned this pull request Jan 26, 2022
Closed
@MaxShvets MaxShvets deleted the fix-mypy-error-when-setting-default-header-matcher branch January 26, 2022 08:34
cailloumajor added a commit to cailloumajor/opcua-webhmi-bridge that referenced this pull request Jan 31, 2022
@cailloumajor
chore: remove type ignore comment
86d362c 
The typing error was fixed in pytest-httpserver v1.0.4.
See csernazs/pytest-httpserver#94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxShvets @csernazs