tests: fix test_verify_assert_msg by setting Accept-Encoding #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accept-Encoding is constructed dynamically by the availability of the compression libraries (eg. zstd, zstandard) so it can result failed test at the end. Fixes #345
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #346 +/- ##
=======================================
Coverage 95.90% 95.90%
=======================================
Files 5 5
Lines 660 660
=======================================
Hits 633 633
Misses 27 27 ☔ View full report in Codecov by Sentry. |
ef14047 to
e3e21a9
Compare
In some cases assert messages are prefixed by 2 spaces and we don't have to be strict here. The key is to compare the contents pytest-httpserver provides, so we split the message by lines and also strip them. Fixes #345
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept-Encoding is constructed dynamically by the availability of the
compression libraries (eg. zstd, zstandard) so it can result failed test at
the end.
Fixes #345