Skip to content

Spaces developments #5217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jul 2, 2025
Merged

Spaces developments #5217

merged 24 commits into from
Jul 2, 2025

Conversation

jessegeens
Copy link
Contributor

  • Extension of the libregraph API regarding sharing
  • Fixes for making listing, restoring, downloading versions work

rodcoffani and others added 23 commits July 2, 2025 16:24
@rodcoffani @jessegeens
shares: fix parent reference
cd7bb97
@rodcoffani @jessegeens
spaces: refactor spaces utils
30a018b 
- reorder functions (encode - decode - parse)
- removed RelativePathToSpaceID
- new function for returning StorageSpaceID
@jessegeens
Implementing libregraph endpoint for updating links/shares
8fd5a83
@jessegeens
WIP: add support for modifying share permissions and removing shares
70ec377
@jessegeens
Fix public links for files
f1241c3
@jessegeens
Unify conversions of share to libregraph perms
39632f8
@jessegeens
fix share creation response
51b0b3f
@jessegeens
implementing update share perms
4a68ded
@jessegeens
Remove unsupported roles from /roleDefinitions endpoint
16f4656
@jessegeens
Limit response length of ListUsers / ListGroups endpoint
fcdb85f
@jessegeens
Add support for removing expiration time from links
12053ab
@jessegeens
Update share manager definition for future support of updating multip…
017f0b5 
…le fields on shares
@jessegeens
Clean up useless debug lines and comments
e915928
@jessegeens
Clean up check for expiration set
6bf4c71
@jessegeens
Add support for updating display name of a link
3a067c8
@jessegeens
Add support for updating share expiration
3e7d9b3
@jessegeens
refactor building share update payload into separate function
633958d
@rodcoffani @jessegeens
feat: add error codes to DAV responses
9419a54 
- adapt code from edge branch (#4749)
@rodcoffani @jessegeens
versions: fix spaceHref
c521283 
- enables version listing
@jessegeens
implement missing ocdav versions API endpoints (#2855)
5e3757e
@rodcoffani @jessegeens
versions: fix version restoring
7e496f4 
- adapt code from #2855
- add parent id to propfind response
- add space info to parent reference
@rodcoffani @jessegeens
eosfs: moved version related functions to utils
1f55f10
@jessegeens
Spaces: make restoring and downloading of versions work
1a497e8
@jessegeens jessegeens force-pushed the spaces branch 3 times, most recently from dc29409 to 45a499b Compare July 2, 2025 14:38
diocas
diocas approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@diocas diocas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping the review since these commits have been reviewed in separate PRs.

@diocas diocas merged commit dfaf124 into master Jul 2, 2025
22 of 25 checks passed
@diocas diocas deleted the spaces branch July 2, 2025 15:07
@diocas diocas restored the spaces branch July 2, 2025 15:07
@jessegeens jessegeens mentioned this pull request Jul 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diocas diocas diocas approved these changes

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jessegeens @diocas @rodcoffani