Skip to content

Conversation

rodcoffani
Copy link
Contributor

@rodcoffani rodcoffani commented Jun 26, 2025

this is a follow-up to #5210

in the new web, these errors are expected in order to handle the password-protected public links

if (err.errorCode === 'ERR_MISSING_BASIC_AUTH') {
  isPasswordRequired.value = true
}
if (err.errorCode === 'ERR_MISSING_BEARER_AUTH') {
  isInternalLink.value = true
}

Copy link

update-docs bot commented Jun 26, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@rodcoffani rodcoffani force-pushed the feat/error-codes-dav-response branch from 736622e to 8e6010e Compare June 26, 2025 12:19
@jessegeens
Copy link
Contributor

Typo in Enhanchement :)

@rodcoffani rodcoffani force-pushed the feat/error-codes-dav-response branch from 8e6010e to ca99e26 Compare June 26, 2025 12:26
@rodcoffani rodcoffani marked this pull request as ready for review June 26, 2025 12:50
@jessegeens jessegeens changed the base branch from feat/update-public-link-endpoint to spaces June 26, 2025 13:56
@diocas diocas changed the base branch from spaces to feat/update-public-link-endpoint June 26, 2025 14:47
@diocas
Copy link
Contributor

diocas commented Jun 26, 2025

@rodcoffani can you add an explanation in this PR as to why this is needed? (some example where is used suffices)

@rodcoffani
Copy link
Contributor Author

@rodcoffani can you add an explanation in this PR as to why this is needed? (some example where is used suffices)

yes! in the new web, these errors are expected in order to handle the password-protected public links:
https://github.com/cernbox/web/blob/dev/packages/web-runtime/src/pages/resolvePublicLink.vue#L148-L158

if (err.errorCode === 'ERR_MISSING_BASIC_AUTH') {
  isPasswordRequired.value = true
}
if (err.errorCode === 'ERR_MISSING_BEARER_AUTH') {
  isInternalLink.value = true
}

@jessegeens jessegeens force-pushed the feat/update-public-link-endpoint branch 2 times, most recently from de118b4 to 2763410 Compare June 26, 2025 15:32
@jessegeens jessegeens changed the base branch from feat/update-public-link-endpoint to spaces June 27, 2025 09:08
@jessegeens jessegeens force-pushed the feat/error-codes-dav-response branch from ca99e26 to 0130c6b Compare June 27, 2025 09:08
- adapt code from edge branch (#4749)
@rodcoffani rodcoffani force-pushed the feat/error-codes-dav-response branch from 0130c6b to 03762d1 Compare June 27, 2025 13:16
@diocas diocas merged commit b9fd230 into spaces Jun 27, 2025
4 of 12 checks passed
@diocas diocas deleted the feat/error-codes-dav-response branch June 27, 2025 13:37
@jessegeens jessegeens mentioned this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants