Skip to content

EOS gRPC cleanup #5201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 1, 2025
Merged

EOS gRPC cleanup #5201

merged 4 commits into from
Jul 1, 2025

Conversation

jessegeens
Copy link
Contributor

@jessegeens jessegeens commented Jun 17, 2025 •
edited
Loading

This PR introduces the following changes to the EOS gRPC driver:

  • We no longer use the binary client for any operation
  • Split up the large single file into multiple files to organize the code a bit
  • Add trace ID to EOS gRPC calls
  • Setting ACL / Sys attrs now happens with the uid of cbox and the gid of daemon. This is needed because we need to have a sudo'er to set the system attributes and daemon to be able to list directories

@update-docs Update Docs
Copy link

update-docs bot commented Jun 17, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@jessegeens jessegeens force-pushed the fix/eos-grpc-cleanup branch 2 times, most recently from 13a4c52 to b051f96 Compare June 17, 2025 06:57
@jessegeens jessegeens marked this pull request as ready for review June 17, 2025 06:59
@jessegeens jessegeens force-pushed the fix/eos-grpc-cleanup branch 2 times, most recently from ff403d4 to 64afa2a Compare June 17, 2025 12:42
@jessegeens jessegeens force-pushed the fix/eos-grpc-cleanup branch from 64afa2a to 1495560 Compare June 17, 2025 14:18
diocas
diocas requested changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@diocas diocas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give it a 2nd round of split and organisation.

@jessegeens jessegeens force-pushed the fix/eos-grpc-cleanup branch from 86b3fd3 to bc9601f Compare June 23, 2025 07:37
@jessegeens jessegeens requested a review from diocas June 23, 2025 07:37
@jessegeens jessegeens merged commit 2ce9e65 into master Jul 1, 2025
14 of 16 checks passed
@jessegeens jessegeens mentioned this pull request Jul 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diocas diocas diocas approved these changes

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessegeens @diocas