Don't set a resource id on the virtual folder root of a public-link-shared file #5252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
2f9e2e6 to
0f9b6e9
Compare
glpatcern
previously approved these changes
Aug 5, 2025
0f9b6e9 to
d29c952
Compare
diocas
requested changes
Aug 5, 2025
d29c952 to
b189d2f
Compare
public-link-shared file
b189d2f to
1ff27d7
Compare
diocas
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The front-end expects to not have a file ID on the root of a public link when it is a virtual folder around a single file share, for it to automatically open in the default app. The file id of this virtual folder has now been removed.
Additionally, this also fixes the
OC-Checksum: Invalid:header on downloads of public link shared files