Skip to content

Conversation

jessegeens
Copy link
Contributor

@jessegeens jessegeens commented Apr 3, 2025

This PR implements several new libregraph API endpoints in ocgraph. These endpoints are used by the updated front-end. Concretely, endpoints have been added for

  • searching users
  • searching groups
  • creating shares
  • creating public links

Copy link

update-docs bot commented Apr 3, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@jessegeens jessegeens force-pushed the feat/users-graph-api branch 19 times, most recently from 635d2e2 to f6c6e2a Compare April 9, 2025 08:19
@jessegeens jessegeens changed the title Users libregraph API v0.1 Spaces libregraph API improvements Apr 9, 2025
@jessegeens jessegeens force-pushed the feat/users-graph-api branch from f6c6e2a to 6f5bdc2 Compare April 10, 2025 07:26
@jessegeens jessegeens force-pushed the feat/users-graph-api branch 2 times, most recently from 0178f14 to 21c25f4 Compare May 6, 2025 12:05
@jessegeens jessegeens marked this pull request as ready for review May 6, 2025 12:06
@jessegeens jessegeens force-pushed the feat/users-graph-api branch from 21c25f4 to fbcdbe5 Compare May 6, 2025 14:52
@rodcoffani

This comment was marked as outdated.

@jessegeens jessegeens force-pushed the feat/users-graph-api branch from fbcdbe5 to 98f878b Compare May 7, 2025 07:35
@jessegeens jessegeens force-pushed the feat/users-graph-api branch from 515964d to 029d4be Compare May 28, 2025 07:41
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't finish the review yet, but to answer one question

@jessegeens jessegeens force-pushed the feat/users-graph-api branch from 8b3c0df to 654cfd6 Compare May 28, 2025 13:39
@jessegeens jessegeens force-pushed the feat/users-graph-api branch from 654cfd6 to 08bb5b3 Compare May 28, 2025 13:47
@jessegeens jessegeens marked this pull request as ready for review May 28, 2025 13:50
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress but we have to clarify a few things as per comments

@jessegeens jessegeens force-pushed the feat/users-graph-api branch from 082c715 to 40204bd Compare June 2, 2025 12:18
@jessegeens jessegeens requested a review from glpatcern June 2, 2025 13:11
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this is good enough and the hard-coded levels can be removed in the future, once we enforce that storage providers always use a tuple (storage_id, space_id, rel_path).

(Now whether that enforcing is a good thing... but the web goes in that direction, as so went OpenCloud internally, so we have to follow).

@glpatcern glpatcern merged commit 8cd6e1a into master Jun 2, 2025
16 checks passed
@jessegeens jessegeens deleted the feat/users-graph-api branch June 16, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants