-
Notifications
You must be signed in to change notification settings - Fork 115
Spaces libregraph API improvements #5134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
635d2e2
to
f6c6e2a
Compare
f6c6e2a
to
6f5bdc2
Compare
0178f14
to
21c25f4
Compare
21c25f4
to
fbcdbe5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
fbcdbe5
to
98f878b
Compare
515964d
to
029d4be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't finish the review yet, but to answer one question
8b3c0df
to
654cfd6
Compare
654cfd6
to
08bb5b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good progress but we have to clarify a few things as per comments
082c715
to
40204bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is good enough and the hard-coded levels can be removed in the future, once we enforce that storage providers always use a tuple (storage_id, space_id, rel_path)
.
(Now whether that enforcing is a good thing... but the web goes in that direction, as so went OpenCloud internally, so we have to follow).
This PR implements several new libregraph API endpoints in
ocgraph
. These endpoints are used by the updated front-end. Concretely, endpoints have been added for