Fix handling Range requests for storages which are not seekable #5133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
… link video previews, returned a 416 response, causing the video player to break
7636c4e to
99e1cc4
Compare
glpatcern
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the video preview in public links is broken, because the browser sends a
Range: bytes=0-request. Since EOS over gRPC returns aReadCloseron the file, which is not seekable, Reva currently returns a416RequestedRangeNotSatisfiableresponse, breaking the video preview.This PR modifies this behaviour to ignore the
Rangerequest in such cases.Additionally, some errors where removed. For example, when the request does not contain
bytes=, Reva currently returns an error. However, RFC 7233 states:Thus, we now ignore these requests instead of returning a
416.