Skip to content

fix: file versions #5190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 1, 2025
Merged

fix: file versions #5190

merged 4 commits into from
Jul 1, 2025

Conversation

rodcoffani
Copy link
Contributor

@rodcoffani rodcoffani commented Jun 6, 2025 •
edited
Loading

Current version listing for spaces crashes when building the file href.

Restoring and downloading: expecting resource id, web-ui sending parent folder id.

Changes:

  • new spaceHref function for versions
  • fix ParseResourceID return, using the SpaceID instead of path

@rodcoffani rodcoffani changed the title versions: fix spaceHref fix: versions spaceHref Jun 6, 2025
jessegeens
jessegeens reviewed Jun 10, 2025
View reviewed changes
jessegeens
jessegeens reviewed Jun 10, 2025
View reviewed changes
@rodcoffani rodcoffani marked this pull request as ready for review June 11, 2025 09:26
@rodcoffani rodcoffani marked this pull request as draft June 11, 2025 09:29
@rodcoffani rodcoffani marked this pull request as ready for review June 11, 2025 11:20
@rodcoffani rodcoffani marked this pull request as draft June 13, 2025 12:01
@rodcoffani rodcoffani changed the base branch from master to spaces June 16, 2025 14:26
@rodcoffani rodcoffani changed the title fix: versions spaceHref fix: file versions Jun 16, 2025
diocas
diocas requested changes Jun 20, 2025
View reviewed changes
@rodcoffani rodcoffani force-pushed the fix/list-versions branch 4 times, most recently from dee975f to 1c8ea83 Compare June 25, 2025 14:54
@rodcoffani rodcoffani marked this pull request as ready for review June 30, 2025 12:10
@rodcoffani
versions: fix version restoring
1ddefa7 
- adapt code from #2855
- add parent id to propfind response
- add space info to parent reference
diocas
diocas approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@diocas diocas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last, quick, mini fix and it's ready to be merged!

@rodcoffani rodcoffani force-pushed the fix/list-versions branch from 8494d6d to 1d771f0 Compare July 1, 2025 08:13
@rodcoffani rodcoffani merged commit 3f25a08 into spaces Jul 1, 2025
10 of 11 checks passed
@rodcoffani rodcoffani deleted the fix/list-versions branch July 1, 2025 08:30
@jessegeens jessegeens mentioned this pull request Jul 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diocas diocas diocas approved these changes

@jessegeens jessegeens jessegeens approved these changes

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodcoffani @diocas @jessegeens