Skip to content

fix: shares parentReference #5189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2025
Merged

fix: shares parentReference #5189

merged 2 commits into from
Jun 20, 2025

Conversation

rodcoffani
Copy link
Contributor

@rodcoffani rodcoffani commented Jun 6, 2025 •
edited
Loading

  • rollback change: replace md.Id.SpaceID with the storageSpaceID.
    • instead of <space-id>, it should use <storage-id>$<space-id>
  • fix: parentReference
    • add space info to id
    • removes double encoding of driveId
    • new function to return relative path inside a space root

@update-docs Update Docs
Copy link

update-docs bot commented Jun 6, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@rodcoffani rodcoffani force-pushed the fix/shares-parent-reference branch from de448c3 to 771eea1 Compare June 6, 2025 13:36
jessegeens
jessegeens reviewed Jun 10, 2025
View reviewed changes
@rodcoffani rodcoffani force-pushed the fix/shares-parent-reference branch 2 times, most recently from ccc7c96 to 36faa19 Compare June 10, 2025 13:29
@rodcoffani rodcoffani marked this pull request as ready for review June 10, 2025 13:51
@rodcoffani rodcoffani marked this pull request as draft June 10, 2025 13:59
@rodcoffani rodcoffani marked this pull request as ready for review June 10, 2025 15:35
@rodcoffani rodcoffani force-pushed the fix/shares-parent-reference branch from 36faa19 to 2a2f929 Compare June 11, 2025 08:52
@rodcoffani
Copy link
Contributor Author

Plugin PR related to parentReference: Add correct mountID to resource parentID

@rodcoffani rodcoffani changed the base branch from master to spaces June 16, 2025 14:26
@rodcoffani rodcoffani requested a review from jessegeens June 16, 2025 14:26
jessegeens
jessegeens requested changes Jun 17, 2025
View reviewed changes
@rodcoffani rodcoffani requested a review from jessegeens June 18, 2025 15:55
@rodcoffani rodcoffani force-pushed the fix/shares-parent-reference branch 2 times, most recently from 2c940cb to bb10593 Compare June 20, 2025 11:32
@rodcoffani rodcoffani force-pushed the fix/shares-parent-reference branch 2 times, most recently from 0b8ef80 to 02d90dc Compare June 20, 2025 14:59
@rodcoffani
shares: fix parent reference
2cd8e48
@rodcoffani
spaces: refactor spaces utils
827d5b9 
- reorder functions (encode - decode - parse)
- removed RelativePathToSpaceID
- new function for returning StorageSpaceID
@rodcoffani rodcoffani force-pushed the fix/shares-parent-reference branch from 02d90dc to 827d5b9 Compare June 20, 2025 15:05
@rodcoffani rodcoffani merged commit 9d1414c into spaces Jun 20, 2025
11 of 12 checks passed
@rodcoffani rodcoffani deleted the fix/shares-parent-reference branch June 20, 2025 15:16
diocas pushed a commit that referenced this pull request Jun 20, 2025
@rodcoffani @diocas
fix: shares parentReference (#5189)
7de7af4
rodcoffani added a commit that referenced this pull request Jun 30, 2025
@rodcoffani
fix: shares parentReference (#5189)
9fa4fcb
@jessegeens jessegeens mentioned this pull request Jul 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessegeens jessegeens jessegeens approved these changes

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

@diocas diocas Awaiting requested review from diocas diocas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodcoffani @jessegeens