Skip to content

feat: add expireDate to capabilities #5158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

feat: add expireDate to capabilities #5158

merged 1 commit into from
May 7, 2025

Conversation

rodcoffani
Copy link
Contributor

No description provided.

@rodcoffani rodcoffani mentioned this pull request May 6, 2025
Merged
@rodcoffani rodcoffani marked this pull request as ready for review May 6, 2025 13:20
glpatcern
glpatcern previously approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, can we actually rename the new struct?

@rodcoffani rodcoffani force-pushed the feat/add-expiredate-capabilities branch from 0ee8294 to eff0445 Compare May 7, 2025 09:56
@glpatcern glpatcern merged commit 1c2d694 into cs3org:master May 7, 2025
16 checks passed
@rodcoffani rodcoffani deleted the feat/add-expiredate-capabilities branch May 7, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpatcern glpatcern glpatcern approved these changes

@diocas diocas Awaiting requested review from diocas diocas is a code owner

@jessegeens jessegeens Awaiting requested review from jessegeens jessegeens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodcoffani @glpatcern