Pseudo-transactionalize sharing #5029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
ed00ee7 to
d159980
Compare
d159980 to
ac1fc44
Compare
glpatcern
previously approved these changes
Jan 7, 2025
ac1fc44 to
3d320c3
Compare
diocas
previously approved these changes
Jan 7, 2025
a02cfef to
71aa634
Compare
71aa634 to
8e2bf89
Compare
glpatcern
reviewed
Jan 13, 2025
glpatcern
reviewed
Jan 13, 2025
de19b5b to
8da19df
Compare
8da19df to
e7d5bfb
Compare
glpatcern
previously approved these changes
Jan 29, 2025
e7d5bfb to
eff11a2
Compare
glpatcern
approved these changes
Jan 29, 2025
glpatcern
pushed a commit
that referenced
this pull request
Feb 3, 2025
Co-authored-by: Jesse Geens <jgeens@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, sharing is not transactionalized: setting ACLs and writing the share to the db is completely independent. In the current situation, shares are written to the db before setting the ACL, letting users falsely believe that they successfully shared a resource, even if setting the ACL afterwards fails. his enhancement improves the situation by doing the least reliable (setting ACLs on EOS) first:
a) first pinging the db
b) writing the ACLs
c) writing to the db