Skip to content

Conversation

0xCLARITY
Copy link
Contributor

Add PNPM support to the GH Action.

I had to explicitly call pnpm config set store-dir to avoid a folder permissions issue with whatever the default store-dir location is.

@CLAassistant
Copy link

CLAassistant commented Aug 3, 2022

CLA assistant check
All committers have signed the CLA.

@0xCLARITY 0xCLARITY mentioned this pull request Aug 3, 2022
@elopez elopez linked an issue Aug 3, 2022 that may be closed by this pull request
@elopez
Copy link
Member

elopez commented Aug 16, 2022

This looks good, thanks! Can you share a link to a sample project using pnpm? It would be handy to have one for testing future changes.

@0xCLARITY
Copy link
Contributor Author

The project I'm working with right now is closed-source. We might open it up later? If you feel it's blocking to have a pnpm sample project I can try to put one together when I have a light afternoon.

@elopez
Copy link
Member

elopez commented Aug 24, 2022

We can go ahead with this, but if you can provide one it'd certainly help to make sure the support doesn't break. I did a quick search for any open source solidity projects using pnpm but didn't find any. It doesn't have to be anything particularly complex or functional, something simple with a dummy contract that showcases pnpm should be okay for testing.

@0xCLARITY
Copy link
Contributor Author

Makes sense. I can throw together something with a dummy contract.

@0xCLARITY
Copy link
Contributor Author

0xCLARITY commented Aug 31, 2022

Here's an example repo. The PR uses my branch for the GH action since it has pnpm support

0xCLARITY/pnpm-slither-example#1

@elopez elopez changed the base branch from main to dev September 5, 2022 20:36
@elopez elopez merged commit 8809f52 into crytic:dev Sep 5, 2022
@0xCLARITY 0xCLARITY deleted the add-pnpm-support branch September 7, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Work with pnpm?
3 participants