chore(entrypoint.sh): better solc detection #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exclude dist folder from the grep
|
|
|
Hi @vzctl, thanks for the PR! Could you provide a bit more context around the change, like which kind of projects have a dist folder, and why is it best to ignore solidity code in it? |
|
Hi! Thanks, updated the PR description with more context. |
|
Sounds good, thanks! We can add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a common practice to set
./distas anoutDircompilation option intsconfig.json(see e.g. here or here).It is also unlikely that
distfolder would contain non-autogenerated files.We are reusing
distas an output destination for autogerenated, hardhat-flattened contracts as well and would like to exclude them from the analysis for solc-detection since flattened contracts also include all the dependencies, similarly tonode_modules.There are two ways of solving the problem:
disttogether withnode_modules(proposed in this PR)