Thanks. Can you write a few integration tests, to check that the targets are built and run, and the exit status properly reported?

For sure. Is there already a way to evaluate the exit status somewhere in the tests? This is my first go with minitest, so it's a little difficult to debug my tests. I see that run from factories.cr is used in the build_test.cr tests.

Tests added, but 2 of them are behaving unexpectedly. I've verified the functionality in a dummy repo and using the bin/shards that is compiled. I'm not too sure why these are behaving differently within the tests.

The 2 tests in question are expected to throw a FailedCommand but are not.

• test_fails_when_multiple_targets_no_arg
• test_fails_when_no_targets_defined

Any help is welcome.

The YAML blocks create a YAML with 2 leading spaces, it should be the following (notice that the blocking YAML is indented):

str = <<-YAML
  name: xxx
  version: 0.0.0
  YAML

Hmm, there appears to be an issue beyond just that. Modifying as suggested did not make a difference.

Yes, youre not changing the current directory in some tests.

Also, I think the run command should just pass STDIN, STDOUT and STDERR as-is. Maybe even replacing the current process with exec — but I'm not sure it's possible with Crystal.

@ysbaddaden Was this something that still needs to be addressed or just a nice to have?

It should really use Process.exec, since we have it bound easily in the stdlib.

@ysbaddaden Anything else needed on this one before getting approved?

@denolfe Specs needs to be rewritten (see #334).

Can we have a spec checking how to pass ARGV values from the shards run command to the actual command? I guess it should be shards run foo -- bar, but I am not sure from the code if that's the idea.

I've confirmed manually that passing ARGV values works, but simulating it using the run function from factories.cr has proven to be difficult. It spits errors out to the console when the test is run saying it cannot read ARGV[0] which is being passed. Here is the WIP test code:

  it "runs specific target with args" do
    File.write(File.join(application_path, "src", "cli_with_args.cr"), "puts __FILE__;args = ARGV[0]")

    File.write File.join(application_path, "shard.yml"), <<-YAML
      name: build
      version: 0.1.0
      targets:
        app:
          main: src/cli_with_args.cr
      YAML

    Dir.cd(application_path) do
      run "shards run app --no-color -- foo"
      File.exists?(bin_path("app")).should be_true
      `#{bin_path("app")}`.chomp.should eq(File.join(application_path, "src", "cli_with_args.cr"))
    end
  end

Could this be something specific with how ARGV is handled in a shell environment vs. through Process.exec? Any help appreciated.

Anything I can do to help move this feature over the finish line?

Can we have a spec checking how to pass ARGV values from the shards run command to the actual command? I guess it should be shards run foo -- bar, but I am not sure from the code if that's the idea.

@silasb The only piece missing was a test for the above. I'm able to verify functionality manually, but testing it properly proved to be difficult because of how the commands are fed to the shell.

I no longer use Crystal personally and don't have time to get these tests running, so I'll be closing this PR out. My branch will still be accessible if someone wanted to use it to finish #157.