Update manpages #505
Merged
Update manpages #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doc sources have been updated in a couple of recent PRs, but the manpages were not re-generated.
Ideally, we should have a CI check to make sure that the manpages are up to date if the sources are changed.
However, I was not yet able to implement a correct validation.
See https://github.com/straight-shoota/shards/commits/fix/manpage-changes for my current approach. It is some trouble to get appropriate SOURCE_DATE_EPOCH. It seems
git log -1 --format='%aI' -- $filereports the date of HEAD instead of the last commit that changed$file. It works as expected locally, but not in CI 🤷