stop expecting master to be the default branch for git #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spec/support/factories.cr
Outdated
| @@ -16,6 +16,9 @@ end | |||
| def create_git_repository(project, *versions) | |||
| Dir.cd(tmp_path) do | |||
| run "git init #{Process.quote(project)}" | |||
| Dir.cd(Process.quote(project)) do | |||
| run "git branch -m master" | |||
There was a problem hiding this comment.
I believe this needs to be git checkout --orphan master because at this point there exists no branch that could be moved with branch -m.
There was a problem hiding this comment.
Both worked on my system, but if you prefer the latter then here it comes.
There was a problem hiding this comment.
The test originally assumed that the default branch is "master". This is not the case for everyone any more. (e.g. I have a default branch called "main"). This PR fixes an assumption of the test that is not correct any more.
If you'd like to change the test to use some other branch name, that, IMHO should be a separate PR.
oprypin
approved these changes
Jun 6, 2021
straight-shoota
approved these changes
Jun 6, 2021
|
Thanks @szabgab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #501