Support LLVM 21.0 (development branch) #15771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
May 12, 2025
|
With this change we should also add a test against LLVM's development branch to LLVM CI. |
straight-shoota
approved these changes
May 13, 2025
|
We have not been escaping our strings properly. The Crystal code |
straight-shoota
approved these changes
May 19, 2025
ysbaddaden
approved these changes
May 19, 2025
straight-shoota
added a commit
to straight-shoota/crystal-book
that referenced
this pull request
Jul 14, 2025
straight-shoota
added a commit
to crystal-lang/crystal-book
that referenced
this pull request
Jul 14, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Crystal waits until a new stable major version of LLVM is released before that version is declared in
src/llvm/ext/llvm-versions.txt, the list of supported LLVM versions. This has proved to be a hassle when maintaining Crystal on software repositories that only distribute the latest versions of each package; LLVM x.1 is often scheduled half to a whole month before a corresponding Crystal 1.y release, during which either Crystal does not run at all (LLVM could use versioned library names), or someone has to explicitly backport LLVM support on our master branch to a preceding Crystal package.With this PR, Crystal now supports the latest LLVM development branch explicitly, in the hopes that unattended transitions from LLVM x.0 to x.1 are smooth. This also means Crystal is now responsible for tracking any upstream LLVM changes as soon as possible.