This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Symbol Initial Implementation #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kofno
approved these changes
Oct 31, 2017
Merged
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #38
This implements initial Symbol support for Scry. I originally started to use
CrystalCtagsbut feel that was kind of written to do something similar but not exactly the same. Some changes would needed to be made to Ctags in order for it to work for Scry's purposes I believe, and it might just be easier to have our own implementation.This PR adds a Scry specific
SymbolVisitorwhich traverses the AST and builds a list of Symbols to be sent as the response. I have only added support for Class/Module/Enum/Struct/Methods in this initial PR. Let me know what you think and if you think this is a good way to proceed!