Don't retain artifacts longer than a day #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `retention-days: 1` to all builds. We upload artifacts so we can publish them to itch and gh-pages, but we don't really need the builds after that. You can quickly run into the 0.75 GB limit from Github free for artifacts that you don't need. While it can also be useful to download artifacts from the Actions page, it seems better to err on the side of making it easy to increase lifetime instead of no clear lifetime.
|
Hi @idbrii thanks for the PR. This is a very appreciated feature. I think it may help most of the users. I don't have much experience with Github CI, but the changes you suggested seems fine. |
|
Okay, sounds good. Thanks for the great template! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
retention-days: 1to all builds. Switched to upload-artifact@v3 (not sure it's necessary).We upload artifacts so we can publish them to itch and gh-pages, but we don't really need the builds after that. You can quickly run into the 0.75 GB limit from Github free for artifacts that are no longer relevant.
While it can also be useful to download artifacts from the Actions page, it seems better to err on the side of making it easy to increase lifetime instead of no clear lifetime.
Draft because I've already hit my Actions storage budget and even deleting all my workflow runs didn't decrease my used Storage for Actions and Packages so I can't actually test this until that quota refills. But I'd still like feedback whether this is a desirable change.
Note: It's also possible to change a repo's artifact retention period, but that would affect Dispatch Export builds which presumably you'd want to keep around longer (I think that's their purpose).