Skip to content

Add Performance/MinMaxAfterMap rule #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2023
Merged

Add Performance/MinMaxAfterMap rule #387

merged 2 commits into from
Jul 10, 2023

Conversation

Sija
Copy link
Member

@Sija Sija commented Jul 10, 2023 •
edited
Loading

This rule is used to identify usage of min/max/minmax calls that follow map.

For example, this is considered invalid:

%w[Alice Bob].map(&.size).min
%w[Alice Bob].map(&.size).max
%w[Alice Bob].map(&.size).minmax

And it should be written as this:

%w[Alice Bob].min_of(&.size)
%w[Alice Bob].max_of(&.size)
%w[Alice Bob].minmax_of(&.size)

@Sija Sija added the rule label Jul 10, 2023
@Sija Sija added this to the 1.5.0 milestone Jul 10, 2023
@Sija Sija requested a review from veelenga July 10, 2023 13:37
@Sija Sija self-assigned this Jul 10, 2023
@Sija Sija force-pushed the feature/minmax-after-map-rule branch from 7a7c055 to ddff8d2 Compare July 10, 2023 13:46
veelenga
veelenga reviewed Jul 10, 2023
View reviewed changes
@Sija @veelenga
Apply suggestions from code review
327ed54 
Co-authored-by: Vitalii Elenhaupt <3624712+veelenga@users.noreply.github.com>
@Sija Sija requested a review from veelenga July 10, 2023 14:09
veelenga
veelenga approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Sija Sija merged commit 33c8273 into master Jul 10, 2023
@Sija Sija deleted the feature/minmax-after-map-rule branch July 10, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veelenga veelenga veelenga approved these changes

Assignees

@Sija Sija

Labels
rule
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Sija @veelenga