Skip to content

Conversation

Sija
Copy link
Member

@Sija Sija commented Jun 30, 2023

Resolves #385

@Sija Sija added the rule label Jun 30, 2023
@Sija Sija added this to the 1.5.0 milestone Jun 30, 2023
@Sija Sija self-assigned this Jun 30, 2023
@Sija Sija changed the title Add Lint/ExcessiveAllocations rule Add Performance/ExcessiveAllocations rule Jun 30, 2023
@Sija Sija requested a review from veelenga June 30, 2023 01:12
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 Still need some tests, no other comments on my end.

@Sija Sija marked this pull request as ready for review June 30, 2023 12:10
@Sija Sija requested a review from veelenga June 30, 2023 12:10
@Sija Sija requested a review from veelenga June 30, 2023 13:18
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sija Sija merged commit 21051ac into master Jun 30, 2023
@Sija Sija deleted the fix-issue-385 branch June 30, 2023 18:58
@bararchy
Copy link

bararchy commented Jul 3, 2023

nice work @Sija

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excessive allocations
3 participants