Support hierarchical loading of the config file #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veelenga
reviewed
Mar 6, 2023
|
@veelenga Should we create v1.4.3 (I guess the last in 1.4.x branch) to release it? WDYT? |
|
I do not have any objections. Let's do that |
There was a problem hiding this comment.
A more DRY approach for read_config would be something like this:
def read_config(file)
each_config_path(file) do |path|
if File.exists?(path)
return File.read(path)
end
end
end
def each_config_path(path)
yield path if path
# ...
search_paths.reverse_each do |search_path|
yield search_path
end
# ...
DEFAULT_PATHS.each do |default_path|
yield default_path
end
end|
@straight-shoota Looks good, I'll do that, thanks! |
|
@straight-shoota Ah, I've forgot about one thing, when |
veelenga
approved these changes
Mar 7, 2023
Sija
commented
Mar 7, 2023
|
If you want completely different behaviour depending on whether |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files are searched for in the same order as used by RuboCop.
Resolves #275