Skip to content

Make boolean rule properties generate query-style methods #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 23, 2022
Merged

Make boolean rule properties generate query-style methods #309

merged 13 commits into from
Nov 23, 2022

Conversation

Sija
Copy link
Member

@Sija Sija commented Nov 22, 2022 

class Foo < Ameba::Rule::Base
  properties do
    description "Disallows foos and possibly bars"
    exclude_bar false
  end
end

# This class definition adds 
# - Foo#exclude_bar (before)
# - Foo#exclude_bar? (now)

@Sija Sija added the refactor label Nov 22, 2022
@Sija Sija added this to the 1.4.0 milestone Nov 22, 2022
@Sija Sija requested a review from veelenga November 22, 2022 18:57
@Sija Sija self-assigned this Nov 22, 2022
veelenga
veelenga approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sija Sija merged commit e7a6b6b into master Nov 23, 2022
@Sija Sija deleted the Sija/refactor-base-rule branch November 23, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veelenga veelenga veelenga approved these changes

Assignees

@Sija Sija

Labels
refactor
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Sija @veelenga