Skip to content

Report unused type declarations in Lint/UselessAssign rule #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 1, 2024
Merged

Report unused type declarations in Lint/UselessAssign rule #430

merged 8 commits into from
Jan 1, 2024

Conversation

Sija
Copy link
Member

@Sija Sija commented Dec 14, 2023 •
edited
Loading

Resolves #429

@Sija Sija added the bug label Dec 14, 2023
@Sija Sija added this to the 1.6.0 milestone Dec 14, 2023
@Sija Sija requested a review from veelenga December 14, 2023 01:37
@Sija Sija self-assigned this Dec 14, 2023
@Sija Sija added the rule label Dec 14, 2023
@Sija Sija marked this pull request as draft December 14, 2023 01:42
@Sija Sija removed this from the 1.6.0 milestone Dec 14, 2023
@Sija
Copy link
Member Author

Sija commented Dec 14, 2023

As type declarations are often used as part of DSLs and within accessor macros, I see no reliable way to mark them as unused assignments.

@Sija Sija closed this Dec 14, 2023
@Sija Sija deleted the fix-issue-429 branch December 14, 2023 02:13
@straight-shoota straight-shoota mentioned this pull request Dec 14, 2023
Closed
@Sija Sija restored the fix-issue-429 branch December 27, 2023 22:48
@Sija Sija reopened this Dec 27, 2023
@Sija Sija force-pushed the fix-issue-429 branch 2 times, most recently from 8723421 to c5f7400 Compare December 27, 2023 22:57
@Sija Sija marked this pull request as ready for review December 27, 2023 22:59
@Sija Sija added this to the 1.6.1 milestone Dec 27, 2023
@Sija
Copy link
Member Author

Sija commented Dec 27, 2023 •
edited
Loading

I'm not happy with these few added # ameba:disable Lint/UselessAssign pragmas, yet I believe it's a sensible price to pay for having this bug fixed.

@veelenga Any idea how this could be optimized?

UPDATE: I've managed to resolve this in #436

@Sija Sija enabled auto-merge December 27, 2023 23:01
@Sija Sija marked this pull request as draft December 27, 2023 23:03
auto-merge was automatically disabled December 27, 2023 23:03

Pull request was converted to draft

@Sija Sija marked this pull request as ready for review December 27, 2023 23:37
@Sija Sija enabled auto-merge December 28, 2023 01:12
@Sija Sija mentioned this pull request Dec 28, 2023
Merged
@Sija
Copy link
Member Author

Sija commented Dec 28, 2023

@veelenga Ready for review.

@veelenga
Copy link
Member

It's a tough one. Need more time to review.

@Sija
Copy link
Member Author

Sija commented Dec 29, 2023

I'm thinking of adding an option to exclude type declarations - in case someone would use 'em in their DSLs, WDYT @veelenga?

veelenga
veelenga approved these changes Jan 1, 2024
View reviewed changes
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No comments/suggestions on my end, good work

@Sija Sija merged commit 452a7a8 into master Jan 1, 2024
@Sija Sija deleted the fix-issue-429 branch January 1, 2024 11:22
@veelenga veelenga mentioned this pull request Mar 22, 2024
Closed
@Blacksmoke16 Blacksmoke16 mentioned this pull request Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veelenga veelenga veelenga approved these changes

Assignees

@Sija Sija

Labels
bug rule
Projects
None yet
Milestone
1.6.1
Development

Successfully merging this pull request may close these issues.

Recognize unused variable from type declaration
2 participants
@Sija @veelenga