Skip to content

Report symbol literals in Naming/AsciiIdentifiers rule #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 14, 2023
Merged

Report symbol literals in Naming/AsciiIdentifiers rule #424

merged 3 commits into from
Nov 14, 2023

Conversation

Sija
Copy link
Member

@Sija Sija commented Nov 14, 2023

No description provided.

@Sija Sija added this to the 1.6.0 milestone Nov 14, 2023
@Sija Sija requested a review from veelenga November 14, 2023 04:02
@Sija Sija self-assigned this Nov 14, 2023
@Sija Sija changed the title Report string literals in Naming/AsciiIdentifiers rule Report symbol literals in Naming/AsciiIdentifiers rule Nov 14, 2023
@Sija Sija force-pushed the report-string-literals-in-ascii-identifiers-rule branch from a1e2b05 to 4ebbc32 Compare November 14, 2023 04:06
@Sija Sija force-pushed the report-string-literals-in-ascii-identifiers-rule branch from 4ebbc32 to 018adb5 Compare November 14, 2023 04:22
@Sija Sija added the rule label Nov 14, 2023
@Sija Sija enabled auto-merge November 14, 2023 04:27
veelenga
veelenga approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sija Sija merged commit 3b87aa6 into master Nov 14, 2023
@Sija Sija deleted the report-string-literals-in-ascii-identifiers-rule branch November 14, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veelenga veelenga veelenga approved these changes

Assignees

@Sija Sija

Labels
enhancement rule
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Sija @veelenga