Skip to content

Mock Time.monotonic #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2021
Merged

Mock Time.monotonic #5

merged 1 commit into from
Feb 23, 2021

Conversation

icy-arctic-fox
Copy link
Contributor

Adds mocking support to Time.monotonic. The freeze, travel, and scale methods cause Time.monotonic to change by the expected amounts.

veelenga
veelenga reviewed Feb 22, 2021
View reviewed changes
robacarp
robacarp approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@robacarp robacarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the concurrency pattern can be deferred until someone wants to refactor all of Timecop to be concurrently friendly.

@veelenga
Copy link
Member

@robacarp ok, please be free to merge.

@robacarp robacarp merged commit 5875a3e into crystal-community:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robacarp robacarp robacarp approved these changes

@veelenga veelenga veelenga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@icy-arctic-fox @veelenga @robacarp