Skip to content

Conversation

dariiing
Copy link
Contributor

@dariiing dariiing commented Nov 5, 2024

Hello,
This PR fixes the order in which you tab through the Kanban boards, closing #1640.

@dariiing dariiing added Kanban Related to Kanban app Accessibility Make software available to everyone Keyboard navigation labels Nov 5, 2024
@dariiing dariiing added this to the Winter release (2024.12.0) milestone Nov 5, 2024
@dariiing dariiing self-assigned this Nov 5, 2024
@dariiing dariiing changed the title Focus order fixes Kanban Focus order fix Nov 5, 2024
@dariiing dariiing added the Ready to Review This PR is ready to be checked by another team member label Nov 11, 2024
@yflory yflory removed the Ready to Review This PR is ready to be checked by another team member label Dec 5, 2024
Copy link
Contributor

@yflory yflory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code "looks" good but after a quick test, I noticed that I can't move the order of boards anymore.
This PR changes a lot the structure of the page but when I look at the issue, it seems it's only a problem with the "+" button so I think there may be an easier solution to fix the issue.

@yflory yflory added the Ready to Test This PR is ready to be tested label Dec 10, 2024
@yflory yflory merged commit 48eabac into staging Dec 12, 2024
@mathilde-cryptpad mathilde-cryptpad deleted the kanban-fixes branch December 18, 2024 10:36
@davidbenque davidbenque removed the Ready to Test This PR is ready to be tested label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Make software available to everyone Kanban Related to Kanban app Keyboard navigation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants