Skip to content

Fix anonymous drive download #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 13, 2025
Merged

Fix anonymous drive download #1784

merged 8 commits into from
Mar 13, 2025

Conversation

Chouhartem
Copy link
Contributor

As reported in #1782, the anonymous file download was not working. Neither from the drive, nor the settings interface.

This PR addresses these two problems.

Chouhartem and others added 3 commits February 13, 2025 16:32
@Chouhartem
Fix contextual menu download from drive UI
4173174 
- Fix folder detection in CryptPad
- Special case for anonymous drive files
- Partly fix #1782
    - Not working yet: full drive download
@Chouhartem
Fix anonymous full drive download
f8442e9 
- Related to #1782
- Anonymous full drive download is now working
    - One known false positive in the test that should not be too bad
      (the behaviour stays the same)
@Chouhartem
Forgot a strict equality
430fbb5
@Chouhartem Chouhartem added Bug There is a problem in our source code Drive Anything related to CryptPad interface, not apps Ready to Review This PR is ready to be checked by another team member labels Feb 13, 2025
@Chouhartem Chouhartem added this to the Spring Release (2025.3.0) milestone Feb 13, 2025
@Chouhartem
style(comments): uniformize comment style
4a6898a 
- Uniformize style for added comments in #1784
@Chouhartem
Fix drive-ui download
30bbf3d 
- Cleaner approach to #1784
- Should work for blobs
@Chouhartem Chouhartem linked an issue Feb 14, 2025 that may be closed by this pull request
Downloads from a guest drive don’t work #1782
Closed
@Chouhartem Chouhartem removed the Ready to Review This PR is ready to be checked by another team member label Feb 19, 2025
@Chouhartem
Remove previous hacky way of guessing isLoggedIn
08deef0 
- Remove reference to `drive.uo.curvePublic` (f8442e9)
- Add `common` information to `data` when sent to `make-backup.js`
@Chouhartem Chouhartem added the Ready to Review This PR is ready to be checked by another team member label Feb 21, 2025
@Chouhartem
Remove an XXX comment
1533b69 
- Not useful anymore (the test is more robust)
@yflory yflory added Ready to Test This PR is ready to be tested and removed Ready to Review This PR is ready to be checked by another team member labels Feb 26, 2025
@mathilde-cryptpad
Copy link
Contributor

Testing: works as expected with Safari on macOS.

@bLaCkwEw bLaCkwEw mentioned this pull request Mar 10, 2025
Closed
@davidbenque davidbenque removed Bug There is a problem in our source code Drive Anything related to CryptPad interface, not apps labels Mar 12, 2025
@yflory yflory merged commit 4a4f384 into staging Mar 13, 2025
@davidbenque davidbenque removed the Ready to Test This PR is ready to be tested label Mar 25, 2025
@mathilde-cryptpad mathilde-cryptpad deleted the guest-download-fix branch April 1, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yflory yflory yflory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Spring Release (2025.3.0)
Development

Successfully merging this pull request may close these issues.

Downloads from a guest drive don’t work
4 participants
@Chouhartem @mathilde-cryptpad @yflory @davidbenque