Skip to content

Conversation

zuzanna-maria
Copy link
Contributor

Fixes #1587 (Form question blocks now have up/down buttons on mobile, allowing re-ordering without drag and drop)

@zuzanna-maria zuzanna-maria self-assigned this Jan 6, 2025
@zuzanna-maria zuzanna-maria changed the base branch from main to staging January 6, 2025 15:06
@davidbenque davidbenque self-requested a review January 8, 2025 14:30
@zuzanna-maria zuzanna-maria added the Ready to Review This PR is ready to be checked by another team member label Jan 17, 2025
Copy link
Contributor

@dariiing dariiing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the initial issue, reordering questions without drag and drop should be available on all devices, which would be particularly helpful for keyboard users. This should be expanded to work across all devices.
(Also I'm not sure how to open the arrow functionality, but this might be an error on my side tbc)

@dariiing dariiing removed the Ready to Review This PR is ready to be checked by another team member label Jan 31, 2025
@zuzanna-maria zuzanna-maria added the Ready to Review This PR is ready to be checked by another team member label Feb 7, 2025
@yflory yflory added the Ready to Test This PR is ready to be tested label Feb 17, 2025
border-radius: @variables_radius 0px 0px @variables_radius;
background-color: @cp_form-bg1;
color: @cryptpad_text_col;
@media (max-width:723px) and (min-width:693px), (max-width:553px) and (min-width:524px), (max-width:379px) and (min-width:350px) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was waiting for @davidbenque to review the .less files, but this type of media-query seems very unreliable. If we make a small change to the rest of the UI, this may have to be changed. Additionally, it doesn't cover all cases if you enable the chat and/or the user list:
image

@mathilde-cryptpad
Copy link
Contributor

Testing: down button doesn't work with Safari on iOS. Only up. Moving the questions by drag and drop work as expected.

ScreenRecording_03-04-2025.13-47-06_1.mp4

@dariiing
Copy link
Contributor

dariiing commented Mar 6, 2025

Testing:

  • Weird double focus around new buttons form (move up/down buttons)
  • there are existing issues with the Form when using a screen reader, but newly added buttons are not announced correctly, or they are announced as "Button"

@yflory yflory merged commit 4b428ec into staging Mar 18, 2025
@davidbenque davidbenque removed Ready to Review This PR is ready to be checked by another team member Ready to Test This PR is ready to be tested labels Mar 25, 2025
@yflory yflory deleted the form_buttons_move_blocks branch March 26, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorder questions should be doable without having to drag and drop
5 participants