-
-
Notifications
You must be signed in to change notification settings - Fork 753
Buttons for moving question blocks in Forms (mobile) #1753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the initial issue, reordering questions without drag and drop should be available on all devices, which would be particularly helpful for keyboard users. This should be expanded to work across all devices.
(Also I'm not sure how to open the arrow functionality, but this might be an error on my side tbc)
www/form/app-form.less
Outdated
border-radius: @variables_radius 0px 0px @variables_radius; | ||
background-color: @cp_form-bg1; | ||
color: @cryptpad_text_col; | ||
@media (max-width:723px) and (min-width:693px), (max-width:553px) and (min-width:524px), (max-width:379px) and (min-width:350px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was waiting for @davidbenque to review the .less files, but this type of media-query seems very unreliable. If we make a small change to the rest of the UI, this may have to be changed. Additionally, it doesn't cover all cases if you enable the chat and/or the user list:
Testing: down button doesn't work with Safari on iOS. Only up. Moving the questions by drag and drop work as expected. ScreenRecording_03-04-2025.13-47-06_1.mp4 |
Testing:
|
+ add missing semi-colon
Fixes #1587 (Form question blocks now have up/down buttons on mobile, allowing re-ordering without drag and drop)