Skip to content

Fix misaligned/missing file dropdown menu items #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 9, 2024
Merged

Fix misaligned/missing file dropdown menu items #1578

merged 10 commits into from
Sep 9, 2024

Conversation

DianaXWiki
Copy link
Contributor

No description provided.

@DianaXWiki DianaXWiki changed the title Misaligned file menu items Fix misaligned/missing file dropdown menu items Jul 29, 2024
@DianaXWiki DianaXWiki added this to the Autumn release (2024.9.0) milestone Jul 29, 2024
davidbenque
davidbenque reviewed Jul 30, 2024
View reviewed changes
@davidbenque
Copy link
Contributor

Approved on the design side but refactoring should be reviewed

@DianaXWiki DianaXWiki added Ready to Review This PR is ready to be checked by another team member Ready to Test This PR is ready to be tested labels Jul 30, 2024
@DianaXWiki
Copy link
Contributor Author

Note: there is still need to find the cause of the missing 'Help' menu item in the Diagram dropdown

@Chouhartem Chouhartem self-requested a review July 30, 2024 15:25
Chouhartem
Chouhartem reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@Chouhartem Chouhartem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactor seems ok for me up to some minor fixes.

@davidbenque davidbenque removed the Ready to Review This PR is ready to be checked by another team member label Aug 20, 2024
yflory
yflory requested changes Aug 22, 2024
View reviewed changes
@davidbenque davidbenque removed the Ready to Test This PR is ready to be tested label Aug 29, 2024
@DianaXWiki DianaXWiki added the Ready to Review This PR is ready to be checked by another team member label Sep 4, 2024
@yflory yflory added Ready to Test This PR is ready to be tested and removed Ready to Review This PR is ready to be checked by another team member labels Sep 4, 2024
@yflory yflory merged commit b040725 into staging Sep 9, 2024
@davidbenque davidbenque removed the Ready to Test This PR is ready to be tested label Dec 6, 2024
@mathilde-cryptpad mathilde-cryptpad deleted the Misaligned-file-menu-items branch December 18, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbenque davidbenque davidbenque left review comments

@yflory yflory yflory approved these changes

@Chouhartem Chouhartem Chouhartem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Autumn release (2024.9.0)
Development

Successfully merging this pull request may close these issues.
4 participants
@DianaXWiki @davidbenque @yflory @Chouhartem