Fix ownership/sharing issues with password-protected pads #1565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The password is sent via `Mailbox` and then is still oblivious to the server - Otherwise a bogus file is created (cryptpad#1522) - Also fix the file stored and fix cryptpad#1521
- Fix cryptpad#1270; - Force reload option added.
- The password should not be asked in this context - Remove deprecated use of the drive secret - Related to cryptpad#1270 and cryptpad#1521
- To avoid some secrets to live outside their intended scope.
Chouhartem
commented
Jul 19, 2024
yflory
approved these changes
Jul 19, 2024
- Use a function to encrypt the password for later use in URLs as it is used both to share a password-protected pad and share ownership of a password-protected pad; - related do cryptpad#1270 and cryptpad#1522.
89fc46d to
8ceccb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues:
Moreover it also fixes an UI error when the preview link when sharing the ownership of a document via CryptPad is broken.
Extra change: make the
block hashaccessible to sharedWorkers.